Skip to content

Conversation

@ikappaki
Copy link
Contributor

Hi,

could you please review patch to set the *print-length* default to nil instead of 50. It addresses #1093.

I’ve also added a docstring (feedback welcome!) and a test.

Thanks

@chrisrink10
Copy link
Member

Change seems fine. I reran the failed jobs since it looks like they failed due to an unrelated issue.

@ikappaki
Copy link
Contributor Author

ikappaki commented Oct 29, 2024

The macOS failures seem to be caused by the Python 3.13 safety installation selecting an outdated pydantic-core version leading to a failed wheel build attempt. Opened pyupio/safety#627 for consultation and updated tox.ini to force picking up the latest pydantic-core version as a workaround.

@chrisrink10 chrisrink10 merged commit cd8fd8a into basilisp-lang:main Oct 30, 2024
12 checks passed
@chrisrink10 chrisrink10 mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants